perf/x86/intel: Fix incorrect MSR index calculations in intel_pmu_config_acr()
authorDapeng Mi <dapeng1.mi@linux.intel.com>
Thu, 29 May 2025 08:02:36 +0000 (08:02 +0000)
committerIngo Molnar <mingo@kernel.org>
Sat, 31 May 2025 08:05:16 +0000 (10:05 +0200)
commit86aa94cd50b138be0dd872b0779fa3036e641881
treed0372bbd912135c68c82279e9a4baeab62863bea
parentdd3922cf9d4d1421e5883614d1a6add912131c00
perf/x86/intel: Fix incorrect MSR index calculations in intel_pmu_config_acr()

The MSR offset calculations in intel_pmu_config_acr() are buggy.

To calculate fixed counter MSR addresses in intel_pmu_config_acr(),
the HW counter index "idx" is subtracted by INTEL_PMC_IDX_FIXED.

This leads to the ACR mask value of fixed counters to be incorrectly
saved to the positions of GP counters in acr_cfg_b[], e.g.

For fixed counter 0, its ACR counter mask should be saved to
acr_cfg_b[32], but it's saved to acr_cfg_b[0] incorrectly.

Fix this issue.

[ mingo: Clarified & improved the changelog. ]

Fixes: ec980e4facef ("perf/x86/intel: Support auto counter reload")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250529080236.2552247-2-dapeng1.mi@linux.intel.com
arch/x86/events/intel/core.c