nvmet: pci-epf: clear completion queue IRQ flag on delete
authorDamien Le Moal <dlemoal@kernel.org>
Thu, 8 May 2025 23:25:00 +0000 (08:25 +0900)
committerChristoph Hellwig <hch@lst.de>
Tue, 13 May 2025 05:57:11 +0000 (07:57 +0200)
commit85adf2094abb9084770dc4ab302aaa9c5d26dd2d
treeb5e0b03b6884ebc2c49a645b1f6e5e29ca547f95
parent3d8932133dcecbd9bef1559533c1089601006f45
nvmet: pci-epf: clear completion queue IRQ flag on delete

The function nvmet_pci_epf_delete_cq() unconditionally calls
nvmet_pci_epf_remove_irq_vector() even for completion queues that do not
have interrupts enabled. Furthermore, for completion queues that do
have IRQ enabled, deleting and re-creating the completion queue leaves
the flag NVMET_PCI_EPF_Q_IRQ_ENABLED set, even if the completion queue
is being re-created with IRQ disabled.

Fix these issues by calling nvmet_pci_epf_remove_irq_vector() only if
NVMET_PCI_EPF_Q_IRQ_ENABLED is set and make sure to always clear that
flag.

Fixes: 0faa0fe6f90e ("nvmet: New NVMe PCI endpoint function target driver")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/pci-epf.c