tipc: Reduce scope for the variable “fdefq” in tipc_link_tnl_prepare()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 13 Apr 2023 15:00:11 +0000 (17:00 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Mar 2025 01:19:49 +0000 (17:19 -0800)
commit859abe3f92d7b3e47264e26f77e53dee651a24b7
tree4f65b2d75f01c6f6748503c71ace885579b2f676
parentea4342739df3da79a2d1a994fb42971d14dd015b
tipc: Reduce scope for the variable “fdefq” in tipc_link_tnl_prepare()

The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the function “tipc_link_tnl_prepare”.

Thus avoid the risk for undefined behaviour by moving the definition
for the local variable “fdefq” into an if branch at the end.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/08fe8fc3-19c3-4324-8719-0ee74b0f32c9@web.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/link.c