block: don't free submitter owned integrity payload on I/O completion
authorChristoph Hellwig <hch@lst.de>
Tue, 2 Jul 2024 15:10:23 +0000 (17:10 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 3 Jul 2024 16:21:16 +0000 (10:21 -0600)
commit85253bac4d02b1f95d6109c221aeccd7a262ec4d
tree14ebb70a5ead12a05e1b4d1270241c399ca00994
parentf8924374fd37a8b41d554acd8b7407af7d354c0d
block: don't free submitter owned integrity payload on I/O completion

Currently __bio_integrity_endio frees the integrity payload unless it is
explicitly marked as user-mapped.  This means in-kernel callers that
allocate their own integrity payload never get to see it on I/O
completion.  The current two users don't need it as they just pre-mapped
PI tuples received over the network, but this limits uses of integrity
data lot.

Change bio_integrity_endio to call __bio_integrity_endio for block layer
generated integrity data only, and leave freeing of submitter
allocated integrity data to bio_uninit which also gets called from
the final bio_put.  This requires that unmapping user mapped or copied
integrity data is now always done by the caller, and the special
BIP_INTEGRITY_USER flag can go away.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240702151047.1746127-6-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio-integrity.c
block/blk.h
include/linux/bio-integrity.h