sched/topology: Move sd_flag_debug out of #ifdef CONFIG_SYSCTL
authorValentin Schneider <valentin.schneider@arm.com>
Tue, 8 Sep 2020 18:49:56 +0000 (19:49 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 9 Sep 2020 08:09:03 +0000 (10:09 +0200)
commit848785df48835eefebe0c4eb5da7690690b0a8b7
treec64f0899585231d407b26001579ff5b64642bf33
parent153908ebc8b5721658c4aba92779fc6e3e2d5a61
sched/topology: Move sd_flag_debug out of #ifdef CONFIG_SYSCTL

The last sd_flag_debug shuffle inadvertently moved its definition within
an #ifdef CONFIG_SYSCTL region. While CONFIG_SYSCTL is indeed required to
produce the sched domain ctl interface (which uses sd_flag_debug to output
flag names), it isn't required to run any assertion on the sched_domain
hierarchy itself.

Move the definition of sd_flag_debug to a CONFIG_SCHED_DEBUG region of
topology.c.

Now at long last we have:

- sd_flag_debug declared in include/linux/sched/topology.h iff
  CONFIG_SCHED_DEBUG=y
- sd_flag_debug defined in kernel/sched/topology.c, conditioned by:
  - CONFIG_SCHED_DEBUG, with an explicit #ifdef block
  - CONFIG_SMP, as a requirement to compile topology.c

With this change, all symbols pertaining to SD flag metadata (with the
exception of __SD_FLAG_CNT) are now defined exclusively within topology.c

Fixes: 8fca9494d4b4 ("sched/topology: Move sd_flag_debug out of linux/sched/topology.h")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200908184956.23369-1-valentin.schneider@arm.com
kernel/sched/debug.c
kernel/sched/topology.c