net: ag71xx: disable napi interrupts during probe
authorSven Eckelmann <sven@narfation.org>
Thu, 5 Sep 2024 19:49:38 +0000 (12:49 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Sep 2024 00:17:39 +0000 (17:17 -0700)
commit8410adf2e38ad32f20edf6d90e049a8203f51d9e
treeddf385c49b007f165af902ce6353acca0a7c8edf
parent40f111cc6e1b35562e815170d8f7efb49bf0fb21
net: ag71xx: disable napi interrupts during probe

ag71xx_probe is registering ag71xx_interrupt as handler for gmac0/gmac1
interrupts. The handler is trying to use napi_schedule to handle the
processing of packets. But the netif_napi_add for this device is
called a lot later in ag71xx_probe.

It can therefore happen that a still running gmac0/gmac1 is triggering the
interrupt handler with a bit from AG71XX_INT_POLL set in
AG71XX_REG_INT_STATUS. The handler will then call napi_schedule and the
napi code will crash the system because the ag->napi is not yet
initialized.

The gmcc0/gmac1 must be brought in a state in which it doesn't signal a
AG71XX_INT_POLL related status bits as interrupt before registering the
interrupt handler. ag71xx_hw_start will take care of re-initializing the
AG71XX_REG_INT_ENABLE.

This will become relevant when dual GMAC devices get added here.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20240905194938.8453-8-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c