drm/xe: prevent potential UAF in pf_provision_vf_ggtt()
authorMatthew Auld <matthew.auld@intel.com>
Wed, 28 Aug 2024 10:43:42 +0000 (11:43 +0100)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 12 Sep 2024 17:29:30 +0000 (12:29 -0500)
commit83dcf232cc7919725a331359a300fb3929651b6e
tree0a73f30db4a8f61f26ac2903854f839bf2a6b617
parentb615b9c36cae0468491547206406a909a9a37f26
drm/xe: prevent potential UAF in pf_provision_vf_ggtt()

The node ptr can point to an already freed ptr, if we hit the path with
an already allocated node. We later dereference that pointer with:

xe_gt_assert(gt, !xe_ggtt_node_allocated(node));

which is a potential UAF. Fix this by not stashing the ptr for node.
Also since it is likely a bad idea to leave config->ggtt_region pointing
to a stale ptr, also set that to NULL by calling
pf_release_vf_config_ggtt() instead of pf_release_ggtt().

Fixes: 34e804220f69 ("drm/xe: Make xe_ggtt_node struct independent")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240828104341.180111-2-matthew.auld@intel.com
(cherry picked from commit 89076b5a8b4e0a01040585e156a0b014cd472fd3)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c