clk: Remove prepare_lock hold assertion in __clk_release()
authorStephen Boyd <sboyd@kernel.org>
Mon, 25 Mar 2024 18:41:55 +0000 (11:41 -0700)
committerStephen Boyd <sboyd@kernel.org>
Mon, 8 Apr 2024 02:29:51 +0000 (19:29 -0700)
commit8358a76cfb47c9a5af627a0c4e7168aa14fa25f6
tree1a6efbedd3767e563ce0ce35cac9d22d4e6c9554
parent4cece764965020c22cff7665b18a012006359095
clk: Remove prepare_lock hold assertion in __clk_release()

Removing this assertion lets us move the kref_put() call outside the
prepare_lock section. We don't need to hold the prepare_lock here to
free memory and destroy the clk_core structure. We've already unlinked
the clk from the clk tree and by the time the release function runs
nothing holds a reference to the clk_core anymore so anything with the
pointer can't access the memory that's being freed anyway. Way back in
commit 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of
prepare_lock") we didn't need to have this assertion either.

Fixes: 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of prepare_lock")
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20240325184204.745706-2-sboyd@kernel.org
drivers/clk/clk.c