xfs: reset XFS_ATTR_INCOMPLETE filter on node removal
authorAndrey Albershteyn <aalbersh@redhat.com>
Wed, 24 Jan 2024 10:26:44 +0000 (11:26 +0100)
committerChandan Babu R <chandanbabu@kernel.org>
Mon, 29 Jan 2024 08:18:10 +0000 (13:48 +0530)
commit82ef1a5356572219f41f9123ca047259a77bd67b
treeb68d973d02619a0f62bbf8b7b2b9b3e79290e361
parent41bccc98fb7931d63d03f326a746ac4d429c1dd3
xfs: reset XFS_ATTR_INCOMPLETE filter on node removal

In XFS_DAS_NODE_REMOVE_ATTR case, xfs_attr_mode_remove_attr() sets
filter to XFS_ATTR_INCOMPLETE. The filter is then reset in
xfs_attr_complete_op() if XFS_DA_OP_REPLACE operation is performed.

The filter is not reset though if XFS just removes the attribute
(args->value == NULL) with xfs_attr_defer_remove(). attr code goes
to XFS_DAS_DONE state.

Fix this by always resetting XFS_ATTR_INCOMPLETE filter. The replace
operation already resets this filter in anyway and others are
completed at this step hence don't need it.

Fixes: fdaf1bb3cafc ("xfs: ATTR_REPLACE algorithm with LARP enabled needs rework")
Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/libxfs/xfs_attr.c