dma-debug: fix return value of __setup handlers
authorRandy Dunlap <rdunlap@infradead.org>
Mon, 28 Feb 2022 22:04:53 +0000 (14:04 -0800)
committerChristoph Hellwig <hch@lst.de>
Thu, 3 Mar 2022 11:01:45 +0000 (14:01 +0300)
commit80e4390981618e290616dbd06ea190d4576f219d
tree4c10afffd63b07f53bc7c0db0b66f930fc5142f4
parentf5ff79fddf0efecca538046b5cc20fb3ded2ec4f
dma-debug: fix return value of __setup handlers

When valid kernel command line parameters
  dma_debug=off dma_debug_entries=100
are used, they are reported as Unknown parameters and added to init's
environment strings, polluting it.

  Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc5
    dma_debug=off dma_debug_entries=100", will be passed to user space.

and

 Run /sbin/init as init process
   with arguments:
     /sbin/init
   with environment:
     HOME=/
     TERM=linux
     BOOT_IMAGE=/boot/bzImage-517rc5
     dma_debug=off
     dma_debug_entries=100

Return 1 from these __setup handlers to indicate that the command line
option has been handled.

Fixes: 59d3daafa1726 ("dma-debug: add kernel command line parameters")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: iommu@lists.linux-foundation.org
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
kernel/dma/debug.c