nvme: fix inconsistent RCU list manipulation in nvme_ns_add_to_ctrl_list()
authorZheng Qixing <zhengqixing@huawei.com>
Tue, 1 Jul 2025 07:17:17 +0000 (15:17 +0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 14 Jul 2025 13:50:32 +0000 (15:50 +0200)
commit80d7762e0a42307ee31b21f090e21349b98c14f6
tree976ae6000a16a80a14b5ef532801fc0bde3090de
parent3051247e4faa32a3d90c762a243c2c62dde310db
nvme: fix inconsistent RCU list manipulation in nvme_ns_add_to_ctrl_list()

When inserting a namespace into the controller's namespace list, the
function uses list_add_rcu() when the namespace is inserted in the middle
of the list, but falls back to a regular list_add() when adding at the
head of the list.

This inconsistency could lead to race conditions during concurrent
access, as users might observe a partially updated list. Fix this by
consistently using list_add_rcu() in both code paths to ensure proper
RCU protection throughout the entire function.

Fixes: be647e2c76b2 ("nvme: use srcu for iterating namespace list")
Signed-off-by: Zheng Qixing <zhengqixing@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c