drm/v3d: Don't run jobs that have errors flagged in its fence
authorMaíra Canal <mcanal@igalia.com>
Thu, 13 Mar 2025 14:43:26 +0000 (11:43 -0300)
committerMaíra Canal <mcanal@igalia.com>
Thu, 13 Mar 2025 19:50:16 +0000 (16:50 -0300)
commit80cbee810e4e13cdbd3ae9654e9ecddf17f3e828
tree813c397d5842777deb464c9949ce8c2fdd58f78b
parenta952f1ab696873be124e31ce5ef964d36bce817f
drm/v3d: Don't run jobs that have errors flagged in its fence

The V3D driver still relies on `drm_sched_increase_karma()` and
`drm_sched_resubmit_jobs()` for resubmissions when a timeout occurs.
The function `drm_sched_increase_karma()` marks the job as guilty, while
`drm_sched_resubmit_jobs()` sets an error (-ECANCELED) in the DMA fence of
that guilty job.

Because of this, we must check whether the job’s DMA fence has been
flagged with an error before executing the job. Otherwise, the same guilty
job may be resubmitted indefinitely, causing repeated GPU resets.

This patch adds a check for an error on the job's fence to prevent running
a guilty job that was previously flagged when the GPU timed out.

Note that the CPU and CACHE_CLEAN queues do not require this check, as
their jobs are executed synchronously once the DRM scheduler starts them.

Cc: stable@vger.kernel.org
Fixes: d223f98f0209 ("drm/v3d: Add support for compute shader dispatch.")
Fixes: 1584f16ca96e ("drm/v3d: Add support for submitting jobs to the TFU.")
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250313-v3d-gpu-reset-fixes-v4-1-c1e780d8e096@igalia.com
drivers/gpu/drm/v3d/v3d_sched.c