of: dynamic: Fix use after free in of_changeset_add_prop_helper()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 22 Aug 2025 08:08:46 +0000 (11:08 +0300)
committerRob Herring (Arm) <robh@kernel.org>
Fri, 22 Aug 2025 21:21:35 +0000 (16:21 -0500)
commit80af3745ca465c6c47e833c1902004a7fa944f37
tree6e5a292c11fd062074d136b937115ab585b7bac6
parentac29e4487aa20a21b7c3facbd1f14f5093835dc9
of: dynamic: Fix use after free in of_changeset_add_prop_helper()

If the of_changeset_add_property() function call fails, then this code
frees "new_pp" and then dereference it on the next line.  Return the
error code directly instead.

Fixes: c81f6ce16785 ("of: dynamic: Fix memleak when of_pci_add_properties() failed")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/aKgljjhnpa4lVpdx@stanley.mountain
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/dynamic.c