NFSD: Avoid calling OPDESC() with ops->opnum == OP_ILLEGAL
authorChuck Lever <chuck.lever@oracle.com>
Fri, 31 Mar 2023 20:31:19 +0000 (16:31 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 31 Mar 2023 21:28:49 +0000 (17:28 -0400)
commit804d8e0a6e54427268790472781e03bc243f4ee3
tree175807635bf83abf9ed564d749633153ae9888f1
parent5f24a8725fe7bc2c6adf7ce00dd3e818387d8995
NFSD: Avoid calling OPDESC() with ops->opnum == OP_ILLEGAL

OPDESC() simply indexes into nfsd4_ops[] by the op's operation
number, without range checking that value. It assumes callers are
careful to avoid calling it with an out-of-bounds opnum value.

nfsd4_decode_compound() is not so careful, and can invoke OPDESC()
with opnum set to OP_ILLEGAL, which is 10044 -- well beyond the end
of nfsd4_ops[].

Reported-by: Jeff Layton <jlayton@kernel.org>
Fixes: f4f9ef4a1b0a ("nfsd4: opdesc will be useful outside nfs4proc.c")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c