gpio/aspeed-sgpio: enable access to all 80 input & output sgpios
authorJeremy Kerr <jk@codeconstruct.com.au>
Fri, 11 Sep 2020 01:51:04 +0000 (09:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Oct 2020 06:02:52 +0000 (08:02 +0200)
commit7dc4222171ce25da56e3d23e9e5b19bb060d48f3
treef54a350ac321869d31b20b611e70bebfb5072316
parent20d7a2cbc3390a4abcde81357ca622875f1bc02a
gpio/aspeed-sgpio: enable access to all 80 input & output sgpios

[ Upstream commit ac67b07e268d46eba675a60c37051bb3e59fd201 ]

Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
corresponding to the 80 status bits available in hardware. Each of these
lines can be configured as either an input or an output.

However, each of these GPIOs is actually an input *and* an output; we
actually have 80 inputs plus 80 outputs.

This change expands the maximum number of GPIOs to 160; the lower half
of this range are the input-only GPIOs, the upper half are the outputs.
We fix the GPIO directions to correspond to this mapping.

This also fixes a bug when setting GPIOs - we were reading from the
input register, making it impossible to set more than one output GPIO.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
drivers/gpio/gpio-aspeed-sgpio.c