m68k: q40: Fix info-leak in rtc_ioctl
authorFuqian Huang <huangfq.daxian@gmail.com>
Fri, 27 Sep 2019 12:15:44 +0000 (20:15 +0800)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 21 Oct 2019 07:08:15 +0000 (09:08 +0200)
commit7cf78b6b12fd5550545e4b73b35dca18bd46b44c
treeb2e36206ad1542a39589063985acb88582382365
parent51b67a6e6592db3b2aa06e870c6546bac095b22b
m68k: q40: Fix info-leak in rtc_ioctl

When the option is RTC_PLL_GET, pll will be copied to userland
via copy_to_user. pll is initialized using mach_get_rtc_pll indirect
call and mach_get_rtc_pll is only assigned with function
q40_get_rtc_pll in arch/m68k/q40/config.c.
In function q40_get_rtc_pll, the field pll_ctrl is not initialized.
This will leak uninitialized stack content to userland.
Fix this by zeroing the uninitialized field.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190927121544.7650-1-huangfq.daxian@gmail.com
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/q40/config.c