soundwire: cadence: Don't overflow the command FIFOs
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Fri, 2 Dec 2022 16:18:10 +0000 (16:18 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 9 Jan 2023 16:06:08 +0000 (21:36 +0530)
commit7cbfee2e2e40d2be54196362a845a3ea0a3f877d
tree8bf276e2fb70f44890b03e5d31aa869d3cde67db
parent5c2f4c9cfc79028079f0691899a93843827a00b7
soundwire: cadence: Don't overflow the command FIFOs

The command FIFOs in the Cadence IP can be configured during design
up to 32 entries, and the code in cadence_master.c was assuming the
full 32-entry FIFO. But all current Intel implementations use an 8-entry
FIFO.

Up to now the longest message used was 6 entries so this wasn't
causing any problem. But future Cirrus Logic codecs have downloadable
firmware or tuning blobs. It is more efficient for the codec driver to
issue long transfers that can take advantage of any queuing in the
Soundwire controller and avoid the overhead of repeatedly writing the
page registers.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fixes: 2f52a5177caa ("soundwire: cdns: Add cadence library")
Link: https://lore.kernel.org/r/20221202161812.4186897-2-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c