ath9k: fix sleeping in atomic context
authorMiaoqing Pan <miaoqing@codeaurora.org>
Mon, 9 Aug 2021 04:05:16 +0000 (12:05 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sun, 29 Aug 2021 07:12:33 +0000 (10:12 +0300)
commit7c48662b9d56666219f526a71ace8c15e6e12f1f
treed6e81d9a0a8b95c0f0c2b63ef401c31a08094329
parent23151b9ae79e3bc4f6a0c4cd3a7f355f68dad128
ath9k: fix sleeping in atomic context

The problem is that gpio_free() can sleep and the cfg_soc() can be
called with spinlocks held. One problematic call tree is:

--> ath_reset_internal() takes &sc->sc_pcu_lock spin lock
   --> ath9k_hw_reset()
      --> ath9k_hw_gpio_request_in()
         --> ath9k_hw_gpio_request()
            --> ath9k_hw_gpio_cfg_soc()

Remove gpio_free(), use error message instead, so we should make sure
there is no GPIO conflict.

Also remove ath9k_hw_gpio_free() from ath9k_hw_apply_gpio_override(),
as gpio_mask will never be set for SOC chips.

Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1628481916-15030-1-git-send-email-miaoqing@codeaurora.org
drivers/net/wireless/ath/ath9k/hw.c