netsec: Remove rcu_read_lock() around XDP program invocation
authorToke Høiland-Jørgensen <toke@redhat.com>
Thu, 24 Jun 2021 16:06:07 +0000 (18:06 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 24 Jun 2021 17:46:12 +0000 (19:46 +0200)
commit7b6ee873ff20c22af355661b241defa7f6ed7582
treeb6da2f486bf7f2f4c65f6bef23aab6793f11a3ff
parent4eb14e3fc6197b7205069ed4e2b31eafa11a0697
netsec: Remove rcu_read_lock() around XDP program invocation

The netsec driver has a rcu_read_lock()/rcu_read_unlock() pair around the
full RX loop, covering everything up to and including xdp_do_flush(). This
is actually the correct behaviour, but because it all happens in a single
NAPI poll cycle (and thus under local_bh_disable()), it is also technically
redundant.

With the addition of RCU annotations to the XDP_REDIRECT map types that
take bh execution into account, lockdep even understands this to be safe,
so there's really no reason to keep the rcu_read_lock() around anymore, so
let's just remove it.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/bpf/20210624160609.292325-18-toke@redhat.com
drivers/net/ethernet/socionext/netsec.c