xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 18 Apr 2018 02:10:15 +0000 (19:10 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 18 Apr 2018 02:10:15 +0000 (19:10 -0700)
commit7b38460dc8e4eafba06c78f8e37099d3b34d473c
tree0f5566cd5ad52f2c14fadceff90508d0504fa969
parent7d83fb14258b9961920cd86f0b921caaeb3ebe85
xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE

Kanda Motohiro reported that expanding a tiny xattr into a large xattr
fails on XFS because we remove the tiny xattr from a shortform fork and
then try to re-add it after converting the fork to extents format having
not removed the ATTR_REPLACE flag.  This fails because the attr is no
longer present, causing a fs shutdown.

This is derived from the patch in his bug report, but we really
shouldn't ignore a nonzero retval from the remove call.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199119
Reported-by: kanda.motohiro@gmail.com
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_attr.c