mm/mremap: fix regression in vrm->new_addr check
authorCarlos Llamas <cmllamas@google.com>
Thu, 28 Aug 2025 14:26:56 +0000 (14:26 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 9 Sep 2025 06:45:11 +0000 (23:45 -0700)
commit78d2d32f0b789d67cbe5cfea0c0714cb2446c37e
tree199c1ef963935d9e78f11aa6dc0bf4752930bce5
parent7989fdce69ec0a928e136477da2aa208a191fba2
mm/mremap: fix regression in vrm->new_addr check

Commit 3215eaceca87 ("mm/mremap: refactor initial parameter sanity
checks") moved the sanity check for vrm->new_addr from mremap_to() to
check_mremap_params().

However, this caused a regression as vrm->new_addr is now checked even
when MREMAP_FIXED and MREMAP_DONTUNMAP flags are not specified.  In this
case, vrm->new_addr can be garbage and create unexpected failures.

Fix this by moving the new_addr check after the vrm_implies_new_addr()
guard.  This ensures that the new_addr is only checked when the user has
specified one explicitly.

Link: https://lkml.kernel.org/r/20250828142657.770502-1-cmllamas@google.com
Fixes: 3215eaceca87 ("mm/mremap: refactor initial parameter sanity checks")
Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Carlos Llamas <cmllamas@google.com>
Cc: Jann Horn <jannh@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mremap.c