ASoC: codec: sma1307: Fix memory corruption in sma1307_setting_loaded()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 29 Aug 2025 12:57:34 +0000 (15:57 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 2 Sep 2025 09:50:27 +0000 (10:50 +0100)
commit78338108b5a856dc98223a335f147846a8a18c51
tree7a25420390d8a78f365887b5e0aad5ab7d59dcc2
parentf54d87dad7619c8026e95b848d6ef677b9f2b55f
ASoC: codec: sma1307: Fix memory corruption in sma1307_setting_loaded()

The sma1307->set.header_size is how many integers are in the header
(there are 8 of them) but instead of allocating space of 8 integers
we allocate 8 bytes.  This leads to memory corruption when we copy data
it on the next line:

        memcpy(sma1307->set.header, data,
               sma1307->set.header_size * sizeof(int));

Also since we're immediately copying over the memory in ->set.header,
there is no need to zero it in the allocator.  Use devm_kmalloc_array()
to allocate the memory instead.

Fixes: 576c57e6b4c1 ("ASoC: sma1307: Add driver for Iron Device SMA1307")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aLGjvjpueVstekXP@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sma1307.c