netdevsim: fix unbalaced locking in nsim_create()
authorTaehee Yoo <ap420073@gmail.com>
Tue, 21 Jul 2020 14:51:50 +0000 (14:51 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 08:19:46 +0000 (10:19 +0200)
commit781cfddfb7321e16d57e59c48ac6f8d215ee9e27
tree126ac62dabdbd56e1bba8dc9ad6870107e9b974c
parentb7a55ea77f50b3cba7fd829e9d4c8a365ef9c7ed
netdevsim: fix unbalaced locking in nsim_create()

[ Upstream commit 2c9d8e01f0c6017317eee7638496173d4a64e6bc ]

In the nsim_create(), rtnl_lock() is called before nsim_bpf_init().
If nsim_bpf_init() is failed, rtnl_unlock() should be called,
but it isn't called.
So, unbalanced locking would occur.

Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/netdevsim/netdev.c