rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Apr 2025 17:22:05 +0000 (20:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 13:58:28 +0000 (15:58 +0200)
commit77feb17c950e03dd0c0d4a64642f3e658679fe3c
tree7514700fb381159f75b38013125039884c6c5206
parent45f0de4f8dc385cd8959d884cd89b3b84c76b7f9
rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send()

The "ret" variable isn't initialized if we don't enter the loop.  For
example,  if "channel->state" is not SMD_CHANNEL_OPENED.

Fixes: 33e3820dda88 ("rpmsg: smd: Use spinlock in tx path")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/aAkhvV0nSbrsef1P@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rpmsg/qcom_smd.c