zstd: Fix array-index-out-of-bounds UBSAN warning
authorNick Terrell <terrelln@fb.com>
Thu, 12 Oct 2023 19:55:34 +0000 (12:55 -0700)
committerNick Terrell <terrelln@meta.com>
Wed, 15 Nov 2023 01:12:52 +0000 (17:12 -0800)
commit77618db346455129424fadbbaec596a09feaf3bb
tree90a0583d90c88694f7198a73fd79d585d8213eae
parentffc253263a1375a65fa6c9f62a893e9767fbebfa
zstd: Fix array-index-out-of-bounds UBSAN warning

Zstd used an array of length 1 to mean a flexible array for C89
compatibility. Switch to a C99 flexible array to fix the UBSAN warning.

Tested locally by booting the kernel and writing to and reading from a
BtrFS filesystem with zstd compression enabled. I was unable to reproduce
the issue before the fix, however it is a trivial change.

Link: https://lkml.kernel.org/r/20231012213428.1390905-1-nickrterrell@gmail.com
Reported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com
Reported-by: Eric Biggers <ebiggers@kernel.org>
Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Nick Terrell <terrelln@fb.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
lib/zstd/common/fse_decompress.c