NFSD: fix use-after-free in __nfs42_ssc_open()
authorDai Ngo <dai.ngo@oracle.com>
Mon, 12 Dec 2022 22:50:11 +0000 (14:50 -0800)
committerChuck Lever <chuck.lever@oracle.com>
Wed, 14 Dec 2022 15:11:54 +0000 (10:11 -0500)
commit75333d48f92256a0dec91dbf07835e804fc411c0
tree60a5e5d9f7cb898684c31021c8ba1d1cc164b192
parent3bc8edc98bd43540dbe648e4ef91f443d6d20a24
NFSD: fix use-after-free in __nfs42_ssc_open()

Problem caused by source's vfsmount being unmounted but remains
on the delayed unmount list. This happens when nfs42_ssc_open()
return errors.

Fixed by removing nfsd4_interssc_connect(), leave the vfsmount
for the laundromat to unmount when idle time expires.

We don't need to call nfs_do_sb_deactive when nfs42_ssc_open
return errors since the file was not opened so nfs_server->active
was not incremented. Same as in nfsd4_copy, if we fail to
launch nfsd4_do_async_copy thread then there's no need to
call nfs_do_sb_deactive

Reported-by: Xingyuan Mo <hdthky0@gmail.com>
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Tested-by: Xingyuan Mo <hdthky0@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4proc.c