smb/client: avoid possible NULL dereference in cifs_free_subrequest()
authorSu Hui <suhui@nfschina.com>
Thu, 8 Aug 2024 12:23:32 +0000 (20:23 +0800)
committerSteve French <stfrench@microsoft.com>
Thu, 15 Aug 2024 20:32:30 +0000 (15:32 -0500)
commit74c2ab6d653b4c2354df65a7f7f2df1925a40a51
tree7023b5c25ac30814e680d9a8863f4bac9bce535e
parent7c626ce4bae1ac14f60076d00eafe71af30450ba
smb/client: avoid possible NULL dereference in cifs_free_subrequest()

Clang static checker (scan-build) warning:
cifsglob.h:line 890, column 3
Access to field 'ops' results in a dereference of a null pointer.

Commit 519be989717c ("cifs: Add a tracepoint to track credits involved in
R/W requests") adds a check for 'rdata->server', and let clang throw this
warning about NULL dereference.

When 'rdata->credits.value != 0 && rdata->server == NULL' happens,
add_credits_and_wake_if() will call rdata->server->ops->add_credits().
This will cause NULL dereference problem. Add a check for 'rdata->server'
to avoid NULL dereference.

Cc: stable@vger.kernel.org
Fixes: 69c3c023af25 ("cifs: Implement netfslib hooks")
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Su Hui <suhui@nfschina.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/file.c