i2c: designware: Remove needless pm_runtime_put_noidle() call
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Tue, 15 Aug 2017 14:34:44 +0000 (17:34 +0300)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 17 Aug 2017 15:55:20 +0000 (17:55 +0200)
commit733f6563979d96dec180c350abb8ac67cc0367ba
tree1c3e47dca92efd9efbe2aefca1f7f57949dfe643
parentf1c0b7e448b9e66dd9a7343bab58a3d3a477e104
i2c: designware: Remove needless pm_runtime_put_noidle() call

I guess pm_runtime_put_noidle() call in i2c_dw_probe_slave() was copied
by accident from similar master mode adapter registration code. It is
unbalanced due missing pm_runtime_get_noresume() but harmless since it
doesn't decrease dev->power.usage_count below zero.

In theory we can hit similar needless runtime suspend/resume cycle
during slave mode adapter registration that was happening when
registering the master mode adapter. See commit cd998ded5c12 ("i2c:
designware: Prevent runtime suspend during adapter registration").

However, since we are slave, we can consider it as a wrong configuration
if we have other slaves attached under this adapter and can omit the
pm_runtime_get_noresume()/pm_runtime_put_noidle() calls for simplicity.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-slave.c