kernfs: fix potential NULL dereference in __kernfs_remove
authorYushan Zhou <katrinzhou@tencent.com>
Thu, 30 Jun 2022 08:25:12 +0000 (16:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Jul 2022 08:36:36 +0000 (10:36 +0200)
commit72b5d5aef246a0387cefa23121dd90901c7a691a
tree9bffd0b9f249efd1ad75b96c367d1fa878aa4336
parentc882716b6d411495f221bdd73e9137357c16a3ea
kernfs: fix potential NULL dereference in __kernfs_remove

When lockdep is enabled, lockdep_assert_held_write would
cause potential NULL pointer dereference.

Fix the following smatch warnings:

fs/kernfs/dir.c:1353 __kernfs_remove() warn: variable dereferenced before check 'kn' (see line 1346)

Fixes: 393c3714081a ("kernfs: switch global kernfs_rwsem lock to per-fs lock")
Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
Link: https://lore.kernel.org/r/20220630082512.3482581-1-zys.zljxml@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/dir.c