btrfs: remove check for NULL fs_info at btrfs_folio_end_lock_bitmap()
authorFilipe Manana <fdmanana@suse.com>
Wed, 6 Nov 2024 12:21:13 +0000 (12:21 +0000)
committerDavid Sterba <dsterba@suse.com>
Mon, 11 Nov 2024 13:34:22 +0000 (14:34 +0100)
commit722d343f12a626c9aee8844f5bf19a107d9a1067
treecabceac075df2a415a5772fb56abadc6cdc31782
parent2342d6595b608eec94187a17dc112dd4c2a812fa
btrfs: remove check for NULL fs_info at btrfs_folio_end_lock_bitmap()

Smatch complains about possibly dereferencing a NULL fs_info at
btrfs_folio_end_lock_bitmap():

  fs/btrfs/subpage.c:332 btrfs_folio_end_lock_bitmap() warn: variable dereferenced before check 'fs_info' (see line 326)

because we access fs_info to set the 'start_bit' variable before doing the
check for a NULL fs_info.

However fs_info is never NULL, since in the only caller of
btrfs_folio_end_lock_bitmap() is extent_writepage(), where we have an
inode which always as a non-NULL fs_info.

So remove the check for a NULL fs_info at btrfs_folio_end_lock_bitmap().

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/subpage.c