virtio-net: lower min ring num_free for efficiency
author? jiang <jiangkidd@hotmail.com>
Tue, 20 Aug 2019 02:51:23 +0000 (02:51 +0000)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 4 Sep 2019 10:21:17 +0000 (06:21 -0400)
commit718be6bab26fb01fa0147a2b614a3eefd96a2957
tree1b11a31a2ef6a4afede5b6fe723ebe00b5670ab5
parent264b563b8675771834419057cbe076c1a41fb666
virtio-net: lower min ring num_free for efficiency

This change lowers ring buffer reclaim threshold from 1/2*queue to budget
for better performance. According to our test with qemu + dpdk, packet
dropping happens when the guest is not able to provide free buffer in
avail ring timely with default 1/2*queue. The value in the patch has been
tested and does show better performance.

Test setup: iperf3 to generate packets to guest (total 30mins, pps 400k, UDP)
avg packets drop before: 2842
avg packets drop after: 360(-87.3%)

Further, current code suffers from a starvation problem: the amount of
work done by try_fill_recv is not bounded by the budget parameter, thus
(with large queues) once in a while userspace gets blocked for a long
time while queue is being refilled. Trigger refills earlier to make sure
the amount of work to do is limited.

Signed-off-by: jiangkidd <jiangkidd@hotmail.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/virtio_net.c