gpio: aggregator: Fix calling into sleeping GPIO controllers
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 31 Jan 2022 10:35:53 +0000 (11:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Feb 2022 11:54:23 +0000 (12:54 +0100)
commit70ea005626a941923fece8fcfd471ea1ba295295
treedaa20a524a5fb4751529d34760d78faa26604ef7
parent0042178a69eb77a979e36a50dcce9794a3140ef8
gpio: aggregator: Fix calling into sleeping GPIO controllers

[ Upstream commit 2cba05451a6d0c703bb74f1a250691404f27c4f1 ]

If the parent GPIO controller is a sleeping controller (e.g. a GPIO
controller connected to I2C), getting or setting a GPIO triggers a
might_sleep() warning.  This happens because the GPIO Aggregator takes
the can_sleep flag into account only for its internal locking, not for
calling into the parent GPIO controller.

Fix this by using the gpiod_[gs]et*_cansleep() APIs when calling into a
sleeping GPIO controller.

Reported-by: Mikko Salomäki <ms@datarespons.se>
Fixes: 828546e24280f721 ("gpio: Add GPIO Aggregator")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-aggregator.c