mtd: onenand: Fix uninitialized retlen in do_otp_read()
authorIvan Stepchenko <sid@itb.spb.ru>
Thu, 14 Nov 2024 13:29:51 +0000 (16:29 +0300)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 5 Dec 2024 10:11:00 +0000 (11:11 +0100)
commit70a71f8151b9879b0950668ce3ad76263261fee0
treef37f716232276b08a2c1787c31fb0421f0b6d59e
parentae461cde5c559675fc4c0ba351c7c31ace705f56
mtd: onenand: Fix uninitialized retlen in do_otp_read()

The function do_otp_read() does not set the output parameter *retlen,
which is expected to contain the number of bytes actually read.
As a result, in onenand_otp_walk(), the tmp_retlen variable remains
uninitialized after calling do_otp_walk() and used to change
the values of the buf, len and retlen variables.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 49dc08eeda70 ("[MTD] [OneNAND] fix numerous races")
Cc: stable@vger.kernel.org
Signed-off-by: Ivan Stepchenko <sid@itb.spb.ru>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/onenand/onenand_base.c