bpf: Transfer RCU lock state between subprog calls
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Mon, 5 Feb 2024 05:56:45 +0000 (05:56 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 6 Feb 2024 04:00:14 +0000 (20:00 -0800)
commit6fceea0fa59f6786a2847a4cae409117624e8b58
tree0756fa0cce159ca3d2eb887f3b4c53fab2e823c5
parent8244ab509f89d63941d5ee207967c5a3e00bb493
bpf: Transfer RCU lock state between subprog calls

Allow transferring an imbalanced RCU lock state between subprog calls
during verification. This allows patterns where a subprog call returns
with an RCU lock held, or a subprog call releases an RCU lock held by
the caller. Currently, the verifier would end up complaining if the RCU
lock is not released when processing an exit from a subprog, which is
non-ideal if its execution is supposed to be enclosed in an RCU read
section of the caller.

Instead, simply only check whether we are processing exit for frame#0
and do not complain on an active RCU lock otherwise. We only need to
update the check when processing BPF_EXIT insn, as copy_verifier_state
is already set up to do the right thing.

Suggested-by: David Vernet <void@manifault.com>
Tested-by: Yafang Shao <laoar.shao@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Acked-by: David Vernet <void@manifault.com>
Link: https://lore.kernel.org/r/20240205055646.1112186-2-memxor@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c