RDMA/mlx4: Remove bogus dev_base_lock usage
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 8 Dec 2020 19:39:28 +0000 (21:39 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 10 Dec 2020 20:58:25 +0000 (16:58 -0400)
commit6f320f6990ee2dd13df89707f1a219ecfe2960ad
treef0b3380a2b1063438d6925ca55a096fa19633496
parente0da68994d16b46384cce7b86eb645f1ef7c51ef
RDMA/mlx4: Remove bogus dev_base_lock usage

It is not clear what this lock protects. If the authors wanted to ensure
that "dev" does not disappear, that is impossible, given the following
code path:

mlx4_ib_netdev_event (under RTNL mutex)
-> mlx4_ib_scan_netdevs
   -> mlx4_ib_update_qps

Also, the dev_base_lock does not protect dev->dev_addr either.

So it serves no purpose here. Remove it.

Link: https://lore.kernel.org/r/20201208193928.1500893-1-vladimir.oltean@nxp.com
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/mlx4/main.c