lib/crypto: arm/poly1305: Remove unneeded empty weak function
authorEric Biggers <ebiggers@kernel.org>
Fri, 11 Jul 2025 21:28:22 +0000 (14:28 -0700)
committerEric Biggers <ebiggers@kernel.org>
Mon, 14 Jul 2025 15:20:00 +0000 (08:20 -0700)
commit6e07c5e166597de1d7943ecf2539cad18c0e2ce1
treea7a9f08be5b71623f795ab24fff63f2e1ffedc96
parent9f65592b7e1f24569bb6ced064df5b4319f725ce
lib/crypto: arm/poly1305: Remove unneeded empty weak function

Fix poly1305-armv4.pl to not do '.globl poly1305_blocks_neon' when
poly1305_blocks_neon() is not defined.  Then, remove the empty __weak
definition of poly1305_blocks_neon(), which was still needed only
because of that unnecessary globl statement.  (It also used to be needed
because the compiler could generate calls to it when
CONFIG_KERNEL_MODE_NEON=n, but that has been fixed.)

Thanks to Arnd Bergmann for reporting that the globl statement in the
asm file was still depending on the weak symbol.

Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250711212822.6372-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
lib/crypto/arm/poly1305-armv4.pl
lib/crypto/arm/poly1305-glue.c