perf metric: Don't remove scale from counts
authorIan Rogers <irogers@google.com>
Fri, 9 Feb 2024 20:49:47 +0000 (12:49 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 13 Feb 2024 21:48:09 +0000 (13:48 -0800)
commit6d6be5eb45b423a37d746d3ee0fd0c78f76ead9f
tree2c8de02ff28a0051f63815ffaba1a8129ec3f57b
parent2543947c77e0e224bda86b4e7220c2f6714da463
perf metric: Don't remove scale from counts

Counts were switched from the scaled saved value form to the
aggregated count to avoid double accounting. When this happened the
removing of scaling for a count should have been removed, however, it
wasn't and this wasn't observed as it normally doesn't matter because
a counter's scale is 1. A problem was observed with RAPL events that
are scaled.

Fixes: 37cc8ad77cf8 ("perf metric: Directly use counts rather than saved_value")
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: James Clark <james.clark@arm.com>
Cc: Kaige Ye <ye@kaige.org>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240209204947.3873294-5-irogers@google.com
tools/perf/util/stat-shadow.c