thermal: core: call put_device() only after device_register() fails
authorViresh Kumar <viresh.kumar@linaro.org>
Wed, 18 Jan 2023 08:38:24 +0000 (14:08 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 19 Jan 2023 20:06:41 +0000 (21:06 +0100)
commit6c54b7bc8a31ce0f7cc7f8deef05067df414f1d8
tree019e8f818f6090a49f16d5f508eb45ef3afbdbc5
parent5dc4c995db9eb45f6373a956eb1f69460e69e6d4
thermal: core: call put_device() only after device_register() fails

put_device() shouldn't be called before a prior call to
device_register(). __thermal_cooling_device_register() doesn't follow
that properly and needs fixing. Also
thermal_cooling_device_destroy_sysfs() is getting called unnecessarily
on few error paths.

Fix all this by placing the calls at the right place.

Based on initial work done by Caleb Connolly.

Fixes: 4748f9687caa ("thermal: core: fix some possible name leaks in error paths")
Fixes: c408b3d1d9bb ("thermal: Validate new state in cur_state_store()")
Reported-by: Caleb Connolly <caleb.connolly@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Frank Rowand <frowand.list@gmail.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Tested-by: Caleb Connolly <caleb.connolly@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/thermal_core.c