drm/xe: Make dma-fences compliant with the safe access rules
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Tue, 10 Jun 2025 16:42:26 +0000 (17:42 +0100)
committerTvrtko Ursulin <tursulin@ursulin.net>
Fri, 13 Jun 2025 07:28:22 +0000 (08:28 +0100)
commit6bd90e700b4285e6a7541e00f969cab0d696adde
tree39df795c9ce57851c601d070a15902608c6be3dc
parent506aa8b02a8d6898c64cc095d233fbae1cef8b8a
drm/xe: Make dma-fences compliant with the safe access rules

Xe can free some of the data pointed to by the dma-fences it exports. Most
notably the timeline name can get freed if userspace closes the associated
submit queue. At the same time the fence could have been exported to a
third party (for example a sync_fence fd) which will then cause an use-
after-free on subsequent access.

To make this safe we need to make the driver compliant with the newly
documented dma-fence rules. Driver has to ensure a RCU grace period
between signalling a fence and freeing any data pointed to by said fence.

For the timeline name we simply make the queue be freed via kfree_rcu and
for the shared lock associated with multiple queues we add a RCU grace
period before freeing the per GT structure holding the lock.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
Link: https://lore.kernel.org/r/20250610164226.10817-5-tvrtko.ursulin@igalia.com
drivers/gpu/drm/xe/xe_guc_exec_queue_types.h
drivers/gpu/drm/xe/xe_guc_submit.c
drivers/gpu/drm/xe/xe_hw_fence.c