phy: ocelot-serdes: fix out-of-bounds read
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 19 Oct 2018 09:21:38 +0000 (11:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Oct 2018 02:27:14 +0000 (19:27 -0700)
commit6acb47d1a318e5b3b7115354ebc4ea060c59d3a1
tree0cfb067435cb242ef1b9e8eef53a4ab5285aaa49
parent81fa7a69c2174ed8de314b9c231ef30a8718e5e1
phy: ocelot-serdes: fix out-of-bounds read

Currently, there is an out-of-bounds read on array ctrl->phys,
once variable i reaches the maximum array size of SERDES_MAX
in the for loop.

Fix this by changing the condition in the for loop from
i <= SERDES_MAX to i < SERDES_MAX.

Addresses-Coverity-ID: 1473966 ("Out-of-bounds read")
Addresses-Coverity-ID: 1473959 ("Out-of-bounds read")
Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing")
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/phy/mscc/phy-ocelot-serdes.c