media: core: v4l2-ioctl: check if ioctl is known to avoid NULL name
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 26 Oct 2023 11:54:01 +0000 (13:54 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 23 Nov 2023 12:01:32 +0000 (13:01 +0100)
commit6aa210d27b5feaf81634973f28b896e208166f4c
tree08f33599089190a91514c81dac0cc24d321f80bf
parent632b8b044a940e415c6d9bd5235778b0db28add1
media: core: v4l2-ioctl: check if ioctl is known to avoid NULL name

When ioctl debugging is turned on, the v4l_printk_ioctl() is used
to log the ioctl that is called. It uses an array of ioctl information
to log the ioctl name and it correctly checks for out-of-bound indexing
of that array. However, the array may have holes since not all ioctl
numbers are used. In that case the name of the ioctl is NULL.

It is harmless (printk handles NULL pointers), but not intended. Instead
use the v4l2_is_known_ioctl() function to determine if the ioctl
information is available or not.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/v4l2-core/v4l2-ioctl.c