arm64: mte: Allow PTRACE_PEEKMTETAGS access to the zero page
authorCatalin Marinas <catalin.marinas@arm.com>
Wed, 10 Feb 2021 18:03:16 +0000 (18:03 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 12 Feb 2021 16:08:31 +0000 (16:08 +0000)
commit68d54ceeec0e5fee4fb8048e6a04c193f32525ca
treeb13558953da871a0dfb7ac1aebbc285fba9317c5
parent22cd5edb2d9c6d68b6ac0fc9584104d88710fa57
arm64: mte: Allow PTRACE_PEEKMTETAGS access to the zero page

The ptrace(PTRACE_PEEKMTETAGS) implementation checks whether the user
page has valid tags (mapped with PROT_MTE) by testing the PG_mte_tagged
page flag. If this bit is cleared, ptrace(PTRACE_PEEKMTETAGS) returns
-EIO.

A newly created (PROT_MTE) mapping points to the zero page which had its
tags zeroed during cpu_enable_mte(). If there were no prior writes to
this mapping, ptrace(PTRACE_PEEKMTETAGS) fails with -EIO since the zero
page does not have the PG_mte_tagged flag set.

Set PG_mte_tagged on the zero page when its tags are cleared during
boot. In addition, to avoid ptrace(PTRACE_PEEKMTETAGS) succeeding on
!PROT_MTE mappings pointing to the zero page, change the
__access_remote_tags() check to (vm_flags & VM_MTE) instead of
PG_mte_tagged.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 34bfeea4a9e9 ("arm64: mte: Clear the tags when a page is mapped in user-space with PROT_MTE")
Cc: <stable@vger.kernel.org> # 5.10.x
Cc: Will Deacon <will@kernel.org>
Reported-by: Luis Machado <luis.machado@linaro.org>
Tested-by: Luis Machado <luis.machado@linaro.org>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lore.kernel.org/r/20210210180316.23654-1-catalin.marinas@arm.com
arch/arm64/kernel/cpufeature.c
arch/arm64/kernel/mte.c