drm/xe/debugfs: fixed the return value of wedged_mode_set
authorXin Wang <x.wang@intel.com>
Thu, 13 Feb 2025 22:36:15 +0000 (06:36 +0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Fri, 14 Feb 2025 15:08:16 +0000 (10:08 -0500)
commit6884d2051011f4db9e2f0b85709c79a8ced13bd6
tree6eb35409c58c747766d976b146f2a57a27d26e47
parentb31e668d3111b100d16fd7db8db335328ce8c6d5
drm/xe/debugfs: fixed the return value of wedged_mode_set

It is generally expected that the write() function should return a
positive value indicating the number of bytes written or a negative
error code if an error occurs. Returning 0 is unusual and can lead
to unexpected behavior.

When the user program writes the same value to wedged_mode twice in
a row, a lockup will occur, because the value expected to be
returned by the write() function inside the program should be equal
to the actual written value instead of 0.

To reproduce the issue:
echo 1 > /sys/kernel/debug/dri/0/wedged_mode
echo 1 > /sys/kernel/debug/dri/0/wedged_mode   <- lockup here

Signed-off-by: Xin Wang <x.wang@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Fei Yang <fei.yang@intel.com>
Cc: Shuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250213223615.2327367-1-x.wang@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_debugfs.c