r8169: Don't disable ASPM in the driver
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Thu, 21 Jun 2018 08:30:38 +0000 (16:30 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Jun 2018 05:07:57 +0000 (14:07 +0900)
commit671646c151d492c3846e6e6797e72ff757b5d65e
tree4b53cb1387037bb9c464cc4405f5c86aae2c10fc
parentcadefe5f584abaac40dce72009e4de738cbff467
r8169: Don't disable ASPM in the driver

Enable or disable ASPM should be done in PCI core instead of in the
device driver.

Commit ba04c7c93bbc ("r8169: disable ASPM") uses
pci_disable_link_state() to disable ASPM, but it's not the best way to
do it. If the device really wants to disable ASPM, we can use a quirk in
PCI core to prevent the PCI core from setting ASPM before probe.

Let's remove pci_disable_link_state() for now. Use PCI core quirks if
any regression happens.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c