drm/nouveau: fix error path in nvkm_gsp_fwsec_v2
authorTimur Tabi <ttabi@nvidia.com>
Wed, 13 Aug 2025 00:10:02 +0000 (19:10 -0500)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 25 Aug 2025 16:09:29 +0000 (18:09 +0200)
commit66e82b6e0a28d4970383e1ee5d60f431001128cd
tree824c0c3b4fbb420ca3b56adc64a6714435aaf438
parente2fe0c54fb7401e6ecd3c10348519ab9e23bd639
drm/nouveau: fix error path in nvkm_gsp_fwsec_v2

Function nvkm_gsp_fwsec_v2() sets 'ret' if the kmemdup() call fails, but
it never uses or returns 'ret' after that point.  We always need to release
the firmware regardless, so do that and then check for error.

Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Cc: stable@vger.kernel.org # v6.7+
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
Link: https://lore.kernel.org/r/20250813001004.2986092-1-ttabi@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/fwsec.c