spi: dw: fix possible race condition
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 17 Jul 2018 14:23:10 +0000 (16:23 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 18 Jul 2018 12:21:33 +0000 (13:21 +0100)
commit66b19d762378785d1568b5650935205edfeb0503
tree397e6a3f84beb9f367dba8f2705ac8cf63f86893
parent2ba87a9bcc7a10aa28af9fbf5b4354b3168366e2
spi: dw: fix possible race condition

It is possible to get an interrupt as soon as it is requested.  dw_spi_irq
does spi_controller_get_devdata(master) and expects it to be different than
NULL. However, spi_controller_set_devdata() is called after request_irq(),
resulting in the following crash:

CPU 0 Unable to handle kernel paging request at virtual address 00000030, epc == 8058e09c, ra == 8018ff90
[...]
Call Trace:
[<8058e09c>] dw_spi_irq+0x8/0x64
[<8018ff90>] __handle_irq_event_percpu+0x70/0x1d4
[<80190128>] handle_irq_event_percpu+0x34/0x8c
[<801901c4>] handle_irq_event+0x44/0x80
[<801951a8>] handle_level_irq+0xdc/0x194
[<8018f580>] generic_handle_irq+0x38/0x50
[<804c6924>] ocelot_irq_handler+0x104/0x1c0

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw.c