drm/amdgpu: Fix lifetime of struct amdgpu_task_info after ring reset
authorAndré Almeida <andrealmeid@igalia.com>
Fri, 4 Jul 2025 03:06:29 +0000 (00:06 -0300)
committerAndré Almeida <andrealmeid@igalia.com>
Thu, 10 Jul 2025 21:41:21 +0000 (18:41 -0300)
commit667efb341917bde19f5d7517b65defcdaed67c9e
tree32b90d4dc9a6129807071e06856bb7ede4f61b26
parentcf590b239c98ff7772c61a9124dbcb5f250e9395
drm/amdgpu: Fix lifetime of struct amdgpu_task_info after ring reset

When a ring reset happens, amdgpu calls drm_dev_wedged_event() using
struct amdgpu_task_info *ti as one of the arguments. After using *ti, a
call to amdgpu_vm_put_task_info(ti) is required to correctly track its
lifetime.

However, it's called from a place that the ring reset path never reaches
due to a goto after drm_dev_wedged_event() is called. Move
amdgpu_vm_put_task_info() bellow the exit label to make sure that it's
called regardless of the code path.

amdgpu_vm_put_task_info() can only accept a valid address or NULL as
argument, so initialise *ti to make sure we can call this function if
*ti isn't used.

Fixes: a72002cb181f ("drm/amdgpu: Make use of drm_wedge_task_info")
Reported-by: Dave Airlie <airlied@gmail.com>
Closes: https://lore.kernel.org/dri-devel/CAPM=9tz0rQP8VZWKWyuF8kUMqRScxqoa6aVdwWw9=5yYxyYQ2Q@mail.gmail.com/
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/r/20250704030629.1064397-1-andrealmeid@igalia.com
Signed-off-by: André Almeida <andrealmeid@igalia.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c