netfs, cifs: Fix mtime/ctime update for mmapped writes
authorDavid Howells <dhowells@redhat.com>
Tue, 17 Sep 2024 07:54:28 +0000 (08:54 +0100)
committerSteve French <stfrench@microsoft.com>
Wed, 25 Sep 2024 02:57:00 +0000 (21:57 -0500)
commit665db14d0712ac27f6a0081510bd811efb3faa3c
tree6813e8ea8299237ccc65d45f7b15dcf2a5f67355
parent387676fabf15f8e772fd22dd05794639115e4216
netfs, cifs: Fix mtime/ctime update for mmapped writes

The cifs flag CIFS_INO_MODIFIED_ATTR, which indicates that the mtime and
ctime need to be written back on close, got taken over by netfs as
NETFS_ICTX_MODIFIED_ATTR to avoid the need to call a function pointer to
set it.

The flag gets set correctly on buffered writes, but doesn't get set by
netfs_page_mkwrite(), leading to occasional failures in generic/080 and
generic/215.

Fix this by setting the flag in netfs_page_mkwrite().

Fixes: 73425800ac94 ("netfs, cifs: Move CIFS_INO_MODIFIED_ATTR to netfs_inode")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202409161629.98887b2-oliver.sang@intel.com
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/netfs/buffered_write.c