nvme: target: fix Kconfig select statements
authorArnd Bergmann <arnd@arndb.de>
Wed, 22 Nov 2023 22:47:18 +0000 (23:47 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 23 Nov 2023 01:40:14 +0000 (18:40 -0700)
commit65e2a74c44ddfa174b700f5da2d1d29b4ba6639b
tree7ed75a0f52739d0f68dd04d331b9eea826a86dc0
parentd78abcbabe7e98bb4baa4dea87550806944790ed
nvme: target: fix Kconfig select statements

When the NVME target code is built-in but its TCP frontend is a loadable
module, enabling keyring support causes a link failure:

x86_64-linux-ld: vmlinux.o: in function `nvmet_ports_make':
configfs.c:(.text+0x100a211): undefined reference to `nvme_keyring_id'

The problem is that CONFIG_NVME_TARGET_TCP_TLS is a 'bool' symbol that
depends on the tristate CONFIG_NVME_TARGET_TCP, so any 'select' from
it inherits the state of the tristate symbol rather than the intended
CONFIG_NVME_TARGET one that contains the actual call.

The same thing is true for CONFIG_KEYS, which itself is required for
NVME_KEYRING.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20231122224719.4042108-3-arnd@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/target/Kconfig