KVM: selftests: Drop the single-underscore ioctl() helpers
authorSean Christopherson <seanjc@google.com>
Wed, 8 Nov 2023 01:09:52 +0000 (17:09 -0800)
committerSean Christopherson <seanjc@google.com>
Wed, 29 Nov 2023 22:51:20 +0000 (14:51 -0800)
commit6542a00369284c951185be8fa2ed45cf423cce06
tree52e0c69f4f50be45086e9002813620016ccd4a9f
parentfc6543bb55d4077c44e577c321bbf158446c8000
KVM: selftests: Drop the single-underscore ioctl() helpers

Drop _kvm_ioctl(), _vm_ioctl(), and _vcpu_ioctl(), as they are no longer
used by anything other than the no-underscores variants (and may have
never been used directly).  The single-underscore variants were never
intended to be a "feature", they were a stopgap of sorts to ease the
conversion to pretty printing ioctl() names when reporting errors.

Opportunistically add a comment explaining when to use __KVM_IOCTL_ERROR()
versus KVM_IOCTL_ERROR().  The single-underscore macros were subtly
ensuring that the name of the ioctl() was printed on error, i.e. it's all
too easy to overlook the fact that using __KVM_IOCTL_ERROR() is
intentional.

Link: https://lore.kernel.org/r/20231108010953.560824-2-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
tools/testing/selftests/kvm/include/kvm_util_base.h